-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ add typed watcher to ClusterCache #11331
✨ add typed watcher to ClusterCache #11331
Conversation
/ok-to-test |
/cc sbueringer |
/cc vincepri |
I need some time to take a look, but I think I have an idea how we could make this a (non-generic) method |
d6f3c78
to
6db51a2
Compare
/test pull-cluster-api-e2e-main |
The new commits take care of this. Now the PR just extend ClusterCache |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/assign @sbueringer
LGTM label has been added. Git tree hash: 01a0f045ce6e30df9a6f9ef612b30adef1d7fde5
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the direction. A few ideas to improve further
6db51a2
to
2e789e5
Compare
/test pull-cluster-api-e2e-main |
2e789e5
to
2e6a3a2
Compare
@sbueringer Addressed all review comments. |
/test pull-cluster-api-e2e-main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last round of nits from my side
2e6a3a2
to
1c26e63
Compare
@ykakarap: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Thank you! Very nice improvement /lgtm /hold |
LGTM label has been added. Git tree hash: f1c105dcf69b9452fc3132e0866255a3af1d4507
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic work!
/approve
/hold cancel
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer, vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
This PR adds support for typed watched to ClusterCache.
This will be specially useful when you want to reconcile a single object on the workload cluster.
With the current API to reconcile a single object on the workload cluster we need to reconcile an object on the mgt cluster that inturn reconciles all objects on the workload cluster.
An example use case when the new API would be useful:
Reconciling a single workload cluster node instead of queueing the CAPI Cluster to then reconciler all workload cluster nodes.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
/area clustercachetracker