-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⚠️ Fix object logging in predicates #11239
⚠️ Fix object logging in predicates #11239
Conversation
@Karthik-K-N: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/assign @chrischdi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Question, should we also add it inside the All
and Any
predicates?
We also have some logging in them where we could populate the object k/v pair 🤔
LGTM label has been added. Git tree hash: c56881622399d616b69e414a5edb96bd5d690ef6
|
Not sure, Why I didn't update them, But now I have updated it in separate commit, Please take a look. |
@Karthik-K-N: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: b2192b6703b273596235507177cb6409edf05727
|
Thx! /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test pull-cluster-api-e2e-main |
Add schemes into predicates (see kubernetes-sigs/cluster-api#11239)
Add schemes into predicates (see kubernetes-sigs/cluster-api#11239)
Add schemes into predicates (see kubernetes-sigs/cluster-api#11239)
Add schemes into predicates (see kubernetes-sigs/cluster-api#11239)
Add schemes into predicates (see kubernetes-sigs/cluster-api#11239)
Add schemes into predicates (see kubernetes-sigs/cluster-api#11239)
Add schemes into predicates (see kubernetes-sigs/cluster-api#11239)
Add schemes into predicates (see kubernetes-sigs/cluster-api#11239)
Add schemes into predicates (see kubernetes-sigs/cluster-api#11239)
Add schemes into predicates (see kubernetes-sigs/cluster-api#11239)
Add schemes into predicates (see kubernetes-sigs/cluster-api#11239)
Add schemes into predicates (see kubernetes-sigs/cluster-api#11239)
Add schemes into predicates (see kubernetes-sigs/cluster-api#11239)
Add schemes into predicates (see kubernetes-sigs/cluster-api#11239)
Add schemes into predicates (see kubernetes-sigs/cluster-api#11239)
Add schemes into predicates (see kubernetes-sigs/cluster-api#11239)
Add schemes into predicates (see kubernetes-sigs/cluster-api#11239)
What this PR does / why we need it:
This PR logs objects kind predicates for easier debugging.
Related PR with same changes for few predicates: #11188
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Part of #10818
/area utils