Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚠️ Fix object logging in predicates #11239

Merged
merged 2 commits into from
Oct 9, 2024

Conversation

Karthik-K-N
Copy link
Contributor

@Karthik-K-N Karthik-K-N commented Sep 30, 2024

What this PR does / why we need it:

This PR logs objects kind predicates for easier debugging.

Related PR with same changes for few predicates: #11188

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Part of #10818

/area utils

@k8s-ci-robot
Copy link
Contributor

@Karthik-K-N: The label(s) area/utils cannot be applied, because the repository doesn't have them.

In response to this:

What this PR does / why we need it:

This PR logs objects kind predicates for easier debugging.

Related PR with same changes for few predicates: #11188

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #10818

/area utils

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 30, 2024
@k8s-ci-robot k8s-ci-robot added do-not-merge/needs-area PR is missing an area label size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 30, 2024
@sbueringer
Copy link
Member

/assign @chrischdi
(for a first round of review when you have some time)

Copy link
Member

@chrischdi chrischdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Question, should we also add it inside the All and Any predicates?

We also have some logging in them where we could populate the object k/v pair 🤔

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 4, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: c56881622399d616b69e414a5edb96bd5d690ef6

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 7, 2024
@k8s-ci-robot k8s-ci-robot requested a review from chrischdi October 7, 2024 08:32
@Karthik-K-N
Copy link
Contributor Author

/lgtm

Question, should we also add it inside the All and Any predicates?

We also have some logging in them where we could populate the object k/v pair 🤔

Not sure, Why I didn't update them, But now I have updated it in separate commit, Please take a look.

@k8s-ci-robot
Copy link
Contributor

@Karthik-K-N: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-apidiff-main 3df1495 link false /test pull-cluster-api-apidiff-main

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link
Member

@chrischdi chrischdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 7, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: b2192b6703b273596235507177cb6409edf05727

@sbueringer sbueringer added the area/util Issues or PRs related to utils label Oct 9, 2024
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/needs-area PR is missing an area label label Oct 9, 2024
@sbueringer
Copy link
Member

Thx!

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 9, 2024
@sbueringer
Copy link
Member

/test pull-cluster-api-e2e-main

@k8s-ci-robot k8s-ci-robot merged commit 7b5489c into kubernetes-sigs:main Oct 9, 2024
24 of 25 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.9 milestone Oct 9, 2024
EmilienM added a commit to shiftstack/cluster-api-provider-openstack that referenced this pull request Nov 12, 2024
@Sunnatillo Sunnatillo mentioned this pull request Nov 19, 2024
54 tasks
EmilienM added a commit to shiftstack/cluster-api-provider-openstack that referenced this pull request Nov 20, 2024
EmilienM added a commit to shiftstack/cluster-api-provider-openstack that referenced this pull request Nov 20, 2024
EmilienM added a commit to shiftstack/cluster-api-provider-openstack that referenced this pull request Nov 20, 2024
EmilienM added a commit to shiftstack/cluster-api-provider-openstack that referenced this pull request Nov 20, 2024
EmilienM added a commit to shiftstack/cluster-api-provider-openstack that referenced this pull request Nov 20, 2024
EmilienM added a commit to shiftstack/cluster-api-provider-openstack that referenced this pull request Nov 20, 2024
EmilienM added a commit to shiftstack/cluster-api-provider-openstack that referenced this pull request Dec 11, 2024
EmilienM added a commit to shiftstack/cluster-api-provider-openstack that referenced this pull request Dec 11, 2024
EmilienM added a commit to shiftstack/cluster-api-provider-openstack that referenced this pull request Dec 11, 2024
EmilienM added a commit to shiftstack/cluster-api-provider-openstack that referenced this pull request Dec 12, 2024
EmilienM added a commit to shiftstack/cluster-api-provider-openstack that referenced this pull request Dec 17, 2024
EmilienM added a commit to shiftstack/cluster-api-provider-openstack that referenced this pull request Dec 30, 2024
MaysaMacedo pushed a commit to shiftstack/cluster-api-provider-openstack that referenced this pull request Dec 30, 2024
MaysaMacedo pushed a commit to shiftstack/cluster-api-provider-openstack that referenced this pull request Jan 2, 2025
MaysaMacedo pushed a commit to shiftstack/cluster-api-provider-openstack that referenced this pull request Jan 2, 2025
EmilienM added a commit to shiftstack/cluster-api-provider-openstack that referenced this pull request Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/util Issues or PRs related to utils cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants