[DONT_REVIEW] 🌱 POC: find all uncached unstructured calls

[sbueringer]

Signed-off-by: Stefan Büringer buringerst@vmware.com

What this PR does / why we need it:
This PR will be used to see if we have any uncached unstructurec calls. In a separate PR we'll cache all unstructured get/list calls.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

[k8s-ci-robot]

This PR is currently missing an area label, which is used to identify the modified component when generating release notes.

Area labels can be added by org members by writing /area ${COMPONENT} in a comment

Please see the labels list for possible areas.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from sbueringer. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[sbueringer]

/test pull-cluster-api-e2e-main

[sbueringer]

This version of CR prints a stacktrace whenever an unstructured uncached get/list is run

(xref: https://github.com/kubernetes-sigs/controller-runtime/compare/release-0.18...sbueringer:controller-runtime:pr-panic-unstructured?expand=1)

[sbueringer]

/test pull-cluster-api-e2e-main

[k8s-ci-robot]

@sbueringer: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-cluster-api-test-main	aa134d4	link	true	/test pull-cluster-api-test-main

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[sbueringer]

Okay found only one additional usage. To summarize. The only places where we used uncached get/list calls for Unstructured on main are:

• MachinePool controller
• Machine controller isDeleteNodeAllowed
• Cluster webhook validateTopologyControlPlaneVersion

I think in all 3 cases it's okay to also use cached calls. So I think it's fine to just always cache unstructured (#10692)

/close

[k8s-ci-robot]

@sbueringer: Closed this PR.

In response to this:

Okay found only one additional usage. To summarize. The only places where we used uncached get/list calls for Unstructured on main are:

• MachinePool controller
• Machine controller isDeleteNodeAllowed
• Cluster webhook validateTopologyControlPlaneVersion

I think in all 3 cases it's okay to also use cached calls. So I think it's fine to just always cache unstructured (#10692)

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.