📖 Document failureReason and Message are considered terminal errors #10561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabriziopandini
added
the
area/documentation
k8s-ci-robot
added
cncf-cla: yes
sbueringer
reviewed
May 7, 2024
docs/book/src/developer/architecture/controllers/control-plane.md
Outdated
Show resolved
Hide resolved
docs/book/src/developer/architecture/controllers/machine-pool.md
Outdated
Show resolved
Hide resolved
docs/book/src/developer/architecture/controllers/machine-pool.md
Outdated
Show resolved
Hide resolved
fabriziopandini
added
the
tide/merge-method-squash
chrischdi
reviewed
May 7, 2024
|
Thx! /lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: a0ec87e0d5bcc26a4a1eb61e01689c3bf22e644e
|
|
/approve /hold for your convenience |
k8s-ci-robot
added
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chrischdi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
k8s-ci-robot
removed
the
lgtm
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: b215bcf549537e4e7a0e133d3a36033eaab871b1
|
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
To document in the book that error surfaced by failureReason and Message are considered terminal errors by CAPI controllers (Fatal error = Terminal error, it cannot be recovered)
Which issue(s) this PR fixes:
Fixes #7191
/area documentation