Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📖 Add members of 1.8 release #10490

Merged
merged 1 commit into from
Apr 26, 2024
Merged

📖 Add members of 1.8 release #10490

merged 1 commit into from
Apr 26, 2024

Conversation

adilGhaffarDev
Copy link
Contributor

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Part of #10472

/area release

@k8s-ci-robot k8s-ci-robot added area/release Issues or PRs related to releasing cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 23, 2024
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 23, 2024
@adilGhaffarDev adilGhaffarDev mentioned this pull request Apr 23, 2024
Closed
37 tasks
@adilGhaffarDev adilGhaffarDev force-pushed the add-rt-1.8-members/adil branch from c5509dc to 9e54249 Compare April 23, 2024 10:41
@sbueringer
Copy link
Member

/approve

Just so you can merge it, I didn't review.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 23, 2024
@chrischdi
Copy link
Member

/ok-to-test

will leave up lgtm to someone else :-) Feel free to ping me if it is finalised

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Apr 23, 2024
chandankumar4
chandankumar4 approved these changes Apr 23, 2024
View reviewed changes
Copy link
Contributor

@chandankumar4 chandankumar4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Communications team members looks good

@k8s-ci-robot
Copy link
Contributor

@chandankumar4: changing LGTM is restricted to collaborators

In response to this:

/lgtm
Communications team members looks good

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@chrischdi
Copy link
Member

/lgtm

/hold for folks to unhold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 23, 2024
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 23, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 27f6e87fbd474f3604468bc5445e305620ddabbd

Sunnatillo
Sunnatillo reviewed Apr 23, 2024
View reviewed changes
Copy link
Contributor

@Sunnatillo Sunnatillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adilGhaffarDev
Add members of 1.8 release
f808642 
Signed-off-by: adil ghaffar <muhammad.adil.ghaffar@est.tech>
@adilGhaffarDev adilGhaffarDev force-pushed the add-rt-1.8-members/adil branch from 9e54249 to f808642 Compare April 24, 2024 12:25
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 24, 2024
@k8s-ci-robot k8s-ci-robot requested a review from chrischdi April 24, 2024 12:25
@adilGhaffarDev
Copy link
Contributor Author

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 25, 2024
@adilGhaffarDev
Copy link
Contributor Author

@chrischdi sorry need lgtm again, one member was missed.

@chrischdi
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 26, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 9669c5f5a150bb93bc405e9c34c79d5477933dce

@k8s-ci-robot k8s-ci-robot merged commit b29e26c into kubernetes-sigs:main Apr 26, 2024
17 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.8 milestone Apr 26, 2024
@Sunnatillo Sunnatillo deleted the add-rt-1.8-members/adil branch May 8, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sunnatillo Sunnatillo Sunnatillo left review comments

@chandankumar4 chandankumar4 chandankumar4 approved these changes

@mcbenjemaa mcbenjemaa Awaiting requested review from mcbenjemaa

@willie-yao willie-yao Awaiting requested review from willie-yao

@chrischdi chrischdi Awaiting requested review from chrischdi

Assignees

@chrischdi chrischdi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release Issues or PRs related to releasing cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.8
Development

Successfully merging this pull request may close these issues.
6 participants
@adilGhaffarDev @sbueringer @k8s-ci-robot @chrischdi @chandankumar4 @Sunnatillo