Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📖 decouple the support new kubernetes version process from kind releases #10414

Merged
merged 5 commits into from
Apr 23, 2024

Conversation

chrischdi
Copy link
Member

@chrischdi chrischdi commented Apr 10, 2024

What this PR does / why we need it:

This PR changes the github template we normally use to track the kubernetes bump.

The change targets to decouple the process of

  • Supporting managing and running on the new Kubernetes version

and

  • waiting for a new kind release / publishing new kindest/node images after a kubernetes release

because the new kind release and/or images get published some time after the final kubernetes minor release.
The changes of:

Allow us to test a released kubernetes version although there are no kindest/node images yet, by building the kindest/node images like we already do for other e2e tests.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

/area documentation

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. area/documentation Issues or PRs related to documentation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 10, 2024
@chrischdi chrischdi changed the title [WIP] 📖 github: adjust kubernetes bump template to decouple kind release and kubernetes version support [WIP] 📖 github: adjust the kubernetes bump process to decouple kind release and kubernetes version support Apr 10, 2024
@chrischdi chrischdi changed the title [WIP] 📖 github: adjust the kubernetes bump process to decouple kind release and kubernetes version support [WIP] 📖 adjust the kubernetes bump process to decouple kind release and kubernetes version support Apr 10, 2024
@chrischdi chrischdi force-pushed the pr-propose-decouple-kind branch from 248a9cf to 5bc3819 Compare April 10, 2024 14:35
@chrischdi chrischdi changed the title [WIP] 📖 adjust the kubernetes bump process to decouple kind release and kubernetes version support [WIP] 📖 decoouple the support new kubernetes version process from kind releases Apr 10, 2024
@chrischdi chrischdi changed the title [WIP] 📖 decoouple the support new kubernetes version process from kind releases [WIP] 📖 decouple the support new kubernetes version process from kind releases Apr 10, 2024
@chrischdi chrischdi force-pushed the pr-propose-decouple-kind branch from 5bc3819 to eb84f3e Compare April 10, 2024 15:09
@chrischdi chrischdi added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Apr 10, 2024
@chrischdi chrischdi changed the title [WIP] 📖 decouple the support new kubernetes version process from kind releases 📖 decouple the support new kubernetes version process from kind releases Apr 10, 2024
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 10, 2024
@chrischdi chrischdi force-pushed the pr-propose-decouple-kind branch from 05bbe36 to 0e25b78 Compare April 10, 2024 15:35
@chrischdi chrischdi force-pushed the pr-propose-decouple-kind branch from 0e25b78 to 62a4b85 Compare April 10, 2024 15:37
@sbueringer
Copy link
Member

Thx!

/lgtm
from my side

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 10, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: c8336e471d7ff98796e34a572716d7619f23ff00

@fabriziopandini
Copy link
Member

/lgtm

@cahillsf @kubernetes-sigs/cluster-api-release-team

@sbueringer
Copy link
Member

sbueringer commented Apr 10, 2024

Just for clarity. The goal of this PR is to restructure the Kubernetes bump tasks in a way that allows us to support a Kubernetes minor release without having to wait for a corresponding kind image release.
Then we only depend on the actual Kubernetes minor release and nothing else.

Copy link
Contributor

@elmiko elmiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the content makes sense to me, i do have a question about the initial prereqs section though.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 12, 2024
@chrischdi chrischdi force-pushed the pr-propose-decouple-kind branch from 544faec to 83c1e08 Compare April 12, 2024 09:25
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 18, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: f515ab1811a481ce8693975c9d7d46546b42ad6c

@sbueringer
Copy link
Member

@chrischdi Sorry not sure if we wanted to wait longer to link some more prior art PRs or if we're done now.
Let me know when we're good and I should take a final look

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 22, 2024
@chrischdi
Copy link
Member Author

@sbueringer updated links. Should be ready to go now

/assign @sbueringer

@sbueringer
Copy link
Member

Thx!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 22, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 16320633f39421bae7dfdd34fcaf88d7dfb45cc6

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 22, 2024
@sbueringer
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Apr 23, 2024
@k8s-ci-robot k8s-ci-robot merged commit 0b61de1 into kubernetes-sigs:main Apr 23, 2024
19 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.8 milestone Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/documentation Issues or PRs related to documentation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants