-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📖 Document the triage process #10367
📖 Document the triage process #10367
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is great, thanks @fabriziopandini , i just had a basic question and a couple nits.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
found some typos.
the process SGTM. i think there are 3 important labels that should always be on tickets.
- kind
- priority
- area
milestone can also be used for planning and triage.
but i see CAPI doesn't use milestones (any more)
is needs-triage
going away too?
one problem with this triage process without milestone or needs-triage would be filtering of tickets that needs triage, it would need a negating query based on priority e.g.
is:issue is:open -label:priority/critical-urgent -label:priority/important-soon -label:priority/important-longterm -label:priority/backlog -label:priorty/awaiting-more-evidence
for kubeadm, since we use milestone it could be just:
is:open is:issue no:milestone
Found a couple of interesting discussions about how things are managed in K8s and why; I'm looking into this: |
5148e97
to
4219f6c
Compare
4219f6c
to
d0a04ae
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
content looks great here, my comments are all minor grammar nits.
Let me know when it's ready for review (just saying in case you forgot to remove "do not review") |
@sbueringer PTAL at your convenience |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a nit, otherwise lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall makes sense to me! just a few nits
Thx! /lgtm /hold |
LGTM label has been added. Git tree hash: dac01833195387d354eb48d112efc38e8d373fa1
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel |
What this PR does / why we need it:
Writing down some practices / lesson learned from bug triage /backlog grooming sessions
/area documentation
/hold
For discussion in the office hours + give time to folks to review