Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Update version matrix for github workflows for release-1.7 #10357

Merged
merged 1 commit into from
Apr 2, 2024
Merged

🌱 Update version matrix for github workflows for release-1.7 #10357

merged 1 commit into from
Apr 2, 2024

Conversation

Sunnatillo
Copy link
Contributor

@Sunnatillo Sunnatillo commented Apr 2, 2024 •
edited
Loading

Update versions in the github actions matrices for the new release.

/area testings

@Sunnatillo
Update version matrix for github workflows
6dc1bc2 
Signed-off-by: Sunnatillo <sunnat.samadov@est.tech>
@k8s-ci-robot
Copy link
Contributor

@Sunnatillo: The label(s) area/testings cannot be applied, because the repository doesn't have them.

In response to this:

Update versions in the github actions matrices for the new release.

/area testings

/hold
Release is not out yet

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-area PR is missing an area label needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 2, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @Sunnatillo. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Sunnatillo Sunnatillo marked this pull request as ready for review April 2, 2024 09:58
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 2, 2024
killianmuldoon
killianmuldoon reviewed Apr 2, 2024
View reviewed changes
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/area ci

(I think)

@k8s-ci-robot k8s-ci-robot added area/ci Issues or PRs related to ci and removed do-not-merge/needs-area PR is missing an area label labels Apr 2, 2024
@chrischdi
Copy link
Member

Let's link the tracking issue too:

Part of:

@chrischdi
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 2, 2024
@Sunnatillo Sunnatillo changed the title 🌱 Update version matrix for github workflows 🌱 Update version matrix for github workflows for release-1.7 Apr 2, 2024
adilGhaffarDev
adilGhaffarDev approved these changes Apr 2, 2024
View reviewed changes
Copy link
Contributor

@adilGhaffarDev adilGhaffarDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 2, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 86ead0d777c2cc6661cb265baeef8469f4e73cf5

@sbueringer
Copy link
Member

sbueringer commented Apr 2, 2024 •
edited
Loading

/approve

We can merge already that's fine (doesn't have to be perfectly synced up imho, it's more important to run security scans on 1.7 than on 1.5)

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 2, 2024
@sbueringer
Copy link
Member

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 2, 2024
@k8s-ci-robot k8s-ci-robot merged commit c8575c9 into kubernetes-sigs:main Apr 2, 2024
34 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.7 milestone Apr 2, 2024
@Sunnatillo Sunnatillo deleted the sunnatillo/update-version-matrix-gh-actions branch April 2, 2024 18:38
@Sunnatillo Sunnatillo mentioned this pull request Aug 26, 2024
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@killianmuldoon killianmuldoon killianmuldoon left review comments

@adilGhaffarDev adilGhaffarDev adilGhaffarDev approved these changes

@enxebre enxebre Awaiting requested review from enxebre

@sbueringer sbueringer Awaiting requested review from sbueringer

Assignees

@adilGhaffarDev adilGhaffarDev

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ci Issues or PRs related to ci cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.7
Development

Successfully merging this pull request may close these issues.
6 participants
@Sunnatillo @k8s-ci-robot @chrischdi @sbueringer @adilGhaffarDev @killianmuldoon