🌱 Add PostCreateNamespace hook to E2E tests #10067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
area/e2e-testing
k8s-ci-robot
added
the
size/L
fabriziopandini
commented
Jan 29, 2024
| @@ -168,6 +172,11 @@ func scaleSpec(ctx context.Context, inputGetter func() scaleSpecInput) { | |||
| LogFolder: filepath.Join(input.ArtifactFolder, "clusters", input.BootstrapClusterProxy.GetName()), | |||
| IgnoreAlreadyExists: true, | |||
| }) | |||
|
|
|||
| if input.PostNamespaceCreated != nil { | |||
There was a problem hiding this comment.
Note: this is the only test that is not using setupSpecNamespace (the reason is explained above; we are pinning namespace name vs creating a name with a random suffix).
|
NOTE: given that the change is clean, non-breaking, and scoped to the test framework only, it would be nice to backport to the 1.6 branch |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: be5f65de2fb9fd5254424aebc596245a07982a22
|
sbueringer
reviewed
Jan 29, 2024
k8s-ci-robot
removed
the
lgtm
sbueringer
reviewed
Jan 29, 2024
fabriziopandini
force-pushed
the
add-postCreateNamespace-hook-to-E2E-tests
branch
from
a9c9e8c to
626a37b
Compare
|
@sbueringer this one should be ready to go now |
sbueringer
added
the
tide/merge-method-squash
|
Thx! /lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 6dca4494913bbde619cd51c56e1d366e770593aa
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
fabriziopandini
deleted the
add-postCreateNamespace-hook-to-E2E-tests
branch
Dhairya-Arora01
pushed a commit
to Dhairya-Arora01/cluster-api
that referenced
this pull request
May 25, 2024
* Add PostCreateNamespace hook to E2E tests * Fix for test who are creating an additional management cluster
Dhairya-Arora01
pushed a commit
to Dhairya-Arora01/cluster-api
that referenced
this pull request
May 25, 2024
* Add PostCreateNamespace hook to E2E tests * Fix for test who are creating an additional management cluster
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds a new PostNamespaceCreated to all E2E tests input objects, thus allowing to inject a function to be run after the test namespace is created. If not specified, this is a no-op.
This can be useful to apply environment settings that apply at the namespace level, eg. setting ResourceQuotas
/area E2E-testing