Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failed to run clusterctl move due to no new finalizers can be added if the object is being deleted #11809

Closed
cprivitere opened this issue Feb 5, 2025 · 6 comments
Closed

Failed to run clusterctl move due to no new finalizers can be added if the object is being deleted #11809

cprivitere opened this issue Feb 5, 2025 · 6 comments
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/flake Categorizes issue or PR as related to a flaky test. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@cprivitere
Copy link
Member

Which jobs are flaking?

periodic-cluster-api-e2e-mink8s-main
periodic-cluster-api-e2e-main
periodic-cluster-api-e2e-release-1-9

Which tests are flaking?

capi-e2e [It] When testing Cluster API working on self-hosted clusters using ClusterClass [ClusterClass] Should pivot the bootstrap cluster to a self-hosted cluster [ClusterClass]
capi-e2e [It] When testing Cluster API working on self-hosted clusters using ClusterClass with a HA control plane [ClusterClass] Should pivot the bootstrap cluster to a self-hosted cluster

Since when has it been flaking?

First spotted instance was on 10/18/2024 at 08:32 AM -https://storage.googleapis.com/k8s-triage/index.html?date=2024-10-30&text=no%20new%20finalizers%20can%20be%20added%20if%20the%20object%20is%20being%20deleted&job=.*cluster-api.*(test%7Ce2e)*&xjob=.*-provider-.*

Testgrid link

https://prow.k8s.io/view/gs/kubernetes-ci-logs/logs/periodic-cluster-api-e2e-mink8s-main/1887038695773573120

Reason for failure (if possible)

Failed to run clusterctl move
Expected success, but got an error:
<...>
Forbidden: no new finalizers can be added if the object is being deleted, found new finalizers...

Anything else we need to know?

These seem to me to be separate from #11162 and #11808 But I could be wrong.

Label(s) to be applied

/kind flake
One or more /area label. See https://github.com/kubernetes-sigs/cluster-api/labels?q=area for the list of labels.
@k8s-ci-robot k8s-ci-robot added kind/flake Categorizes issue or PR as related to a flaky test. needs-priority Indicates an issue lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Feb 5, 2025
@cprivitere cprivitere changed the title Failed to run clusterctl move due failing to get API group resources Failed to run clusterctl move due to no new finalizers can be added if the object is being deleted Feb 5, 2025
@cprivitere cprivitere mentioned this issue Feb 6, 2025
Closed
@fabriziopandini
Copy link
Member

Can we close this issue given that #11814 is merged

@fabriziopandini fabriziopandini added the triage/accepted Indicates an issue or PR is ready to be actively worked on. label Feb 13, 2025
@k8s-ci-robot k8s-ci-robot removed the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Feb 13, 2025
@fabriziopandini fabriziopandini added help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed kind/flake Categorizes issue or PR as related to a flaky test. triage/accepted Indicates an issue or PR is ready to be actively worked on. needs-priority Indicates an issue lacks a `priority/foo` label and requires one. labels Feb 13, 2025
@k8s-ci-robot k8s-ci-robot added needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Feb 13, 2025
@fabriziopandini fabriziopandini added kind/flake Categorizes issue or PR as related to a flaky test. triage/accepted Indicates an issue or PR is ready to be actively worked on. labels Feb 13, 2025
@k8s-ci-robot k8s-ci-robot removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Feb 13, 2025
@sbueringer
Copy link
Member

sbueringer commented Feb 13, 2025 •
edited
Loading

I'm not sure if this is the same issue or even the same root cause (that we changed the order in the controller).

@sbueringer
Copy link
Member

sbueringer commented Feb 13, 2025 •
edited
Loading

I think #11814 might have fixed it.

The following seems to happen

  1. we move the cluster: deletion on the source cluster doesn't go through
  2. ...
  3. we move back: we can't add new finalizer because the object is still deleting

@sbueringer
Copy link
Member

@cprivitere I would suggest to wait another week and then close the issue if it doesn't occur until then

(we can reopen if it fails again, but I'm relatively confident that it's fixed)

@cprivitere
Copy link
Member Author

As the issue hasn't re-occurred, we can go ahead and close this. Thanks everyone.

/close

@k8s-ci-robot
Copy link
Contributor

@cprivitere: Closing this issue.

In response to this:

As the issue hasn't re-occurred, we can go ahead and close this. Thanks everyone.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/flake Categorizes issue or PR as related to a flaky test. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@sbueringer @fabriziopandini @k8s-ci-robot @cprivitere