Skip to content

Commit

Permalink
Use TODO instead of FIXME consistently
Browse files Browse the repository at this point in the history
Signed-off-by: Stefan Büringer buringerst@vmware.com
  • Loading branch information
sbueringer committed Oct 1, 2024
1 parent 65fbabe commit a7cfa99
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion cmd/clusterctl/client/cluster/mover.go
Original file line number Diff line number Diff line change
Expand Up @@ -963,7 +963,7 @@ func (o *objectMover) createTargetObject(ctx context.Context, nodeToCreate *node
// Rebuild the owner reference chain
o.buildOwnerChain(obj, nodeToCreate)

// FIXME Workaround for https://github.com/kubernetes/kubernetes/issues/32220. Remove when the issue is fixed.
// TODO Workaround for https://github.com/kubernetes/kubernetes/issues/32220. Remove when the issue is fixed.
// If the resource already exists, the API server ordinarily returns an AlreadyExists error. Due to the above issue, if the resource has a non-empty metadata.generateName field, the API server returns a ServerTimeoutError. To ensure that the API server returns an AlreadyExists error, we set the metadata.generateName field to an empty string.
if obj.GetName() != "" && obj.GetGenerateName() != "" {
obj.SetGenerateName("")
Expand Down
2 changes: 1 addition & 1 deletion cmd/clusterctl/client/repository/repository_gitlab.go
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ func (g *gitLabRepository) DefaultVersion() string {

// GetVersions returns the list of versions that are available in a provider repository.
func (g *gitLabRepository) GetVersions(_ context.Context) ([]string, error) {
// FIXME Get versions from GitLab API
// TODO Get versions from GitLab API
return []string{g.defaultVersion}, nil
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1420,7 +1420,7 @@ func TestMachineHealthCheck_Reconcile(t *testing.T) {
})

t.Run("when a machine is paused", func(t *testing.T) {
// FIXME: Resolve flaky/failing test
// TODO: Resolve flaky/failing test
t.Skip("skipping until made stable")
g := NewWithT(t)
cluster := createCluster(g, ns.Name)
Expand Down

0 comments on commit a7cfa99

Please sign in to comment.