remove kind the binary as a dependnecy
#56
Conversation
Bump the kind library dep to v0.4.0 Signed-off-by: Chuck Ha <chuckh@vmware.com>
k8s-ci-robot
added
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chuckha The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
Signed-off-by: Chuck Ha <chuckh@vmware.com>
Signed-off-by: Chuck Ha <chuckh@vmware.com>
Signed-off-by: Chuck Ha <chuckh@vmware.com>
Signed-off-by: Chuck Ha <chuckh@vmware.com>
|
/hold cancel Ready to go! |
k8s-ci-robot
removed
the
do-not-merge/hold
| // start kind with docker mount | ||
| kindConfig, err := kindConfigFile() | ||
| fmt.Println("Creating a brand new cluster") | ||
| elb, err := actions.SetUpLoadBalancer(clusterName) | ||
| if err != nil { | ||
| panic(err) |
There was a problem hiding this comment.
out of scope of this PR, but the panic() pattern here is not recommended.
errors should bubble up to an exit(1).
There was a problem hiding this comment.
Right now i'm keeping panic for consistency. I opened #8 to get a new contributor involved but will probably timeout on the issue soon since this can't live for much longer
| @@ -149,13 +150,23 @@ func KubeadmInit(clusterName string) error { | |||
| if err != nil { | |||
| return err | |||
| } | |||
| // Upload certs flag changed to non-experimental in >= 1.15 | |||
| uploadCertsFlag := "--experimental-upload-certs" | |||
| parsedVersion, err := k8sverison.ParseGeneric(version) | |||
There was a problem hiding this comment.
should be ParseSemantic? generic will fail parsing a k8s version with pre-release + metadata.
There was a problem hiding this comment.
that's ok, we won't be using those tags (yet). if we do end up needing it we can change it later
|
closes #28 |
|
/lgtm |
Bump the kind library dep to v0.4.0
Signed-off-by: Chuck Ha chuckh@vmware.com
What this PR does / why we need it:
This PR now creates the management cluster using the same functions that the actuators use to build regular control plane nodes. No more nested containers.
We need this because of node-ref. The container images that contain a kubernetes must share the same network so that node-ref controller can talk to child clusters. Without this there is no way to shove the network down into containerd land inside the kind node.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #55
Special notes for your reviewer:
Release note:
I'm adding a hold so I can work on the README before this merges.
/hold