Add option for custom status readers #383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/invalid-commit-message
k8s-ci-robot
added
the
size/S
This commit adds the `CustomStatusReadersFactoryFunc` option to the StatusPoller's `Poll` method options so that consumers can provide custom status readers for certain GroupKinds (esp. CRDs). It also changes the `NewGenericStatusReader` func so that it accepts a statusFunc parameter so that consumers only have to implement that single func and use the genericStatusReader for all the boilerplate stuff (like fetching an object from the API). refs kubernetes-sigs#382
makkes
force-pushed
the
custom-reader-status
branch
from
1b9ed40 to
5b7b824
Compare
k8s-ci-robot
removed
the
do-not-merge/invalid-commit-message
mortent
reviewed
Jul 9, 2021
k8s-ci-robot
added
size/M
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: makkes, mortent The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds the
CustomStatusReadersFactoryFuncoption to theStatusPoller's
Pollmethod options so that consumers can providecustom status readers for certain GroupKinds (esp. CRDs).
It also changes the
NewGenericStatusReaderfunc so that it accepts astatusFunc parameter so that consumers only have to implement that
single func and use the genericStatusReader for all the boilerplate
stuff (like fetching an object from the API).
refs #382