Multiple bug fixes and doc enhancements

[M00nF1sh]

The PR is separated into 6 independent commit: (review each one individually by click on "Commits" tab.

1. fix default action comparison: Fix When running by target-type:ip on EKS, ingress targetgroup changes occur due to the increase or decrease of unrelated nodes ASG #1163 .
   The default action from ALB contains both targetGroupARN in top level Action structure, and also contain targetGroupARN in forwardAction structure. While desiredAction build only contains it in forwardAction structure. Use dedicated compare method instead of deepEqual to avoid unnecessary modification.
2. issue warning when an targetGroup for k8s service is referenced by ARN: Fix Advanced routing option gives: failed to GC targetGroups due to failed to delete targetGroup due to ResourceInUse #1140
   There are users used TargetGroupArn in action configuration even if the targetGroup is created for a k8s service by controller. The controller will try to delete that targetGroup(though the deletion will fail due to dependencies).
   This commit will issue a warning to user and bypass deletion under such misusage.
3. various docs enhancements: close Multiple separate rules with the same target group #1150, close Document HTTPS requirement for Cognito/OIDC authentication #1149
   1. make it clear authentication is only supported for HTTPS listener
   2. make it clear that conditions annotation is supported for both normal serviceName and annotation based action name.
   3. make it clear that forward-multiple-tg supports multiple k8s service as well.
   4. fix make docs-serve and make docs-deploy by install dependencies first.
4. set default log level to be 2 for more verbose message: sets default log level to 2, which will emit "successfully reconciled" message from controller-runtime, which is useful for most ppl.
5. make subnet resolve message more clear: make the subnet tagging requirement message more clear:

   failed to build LoadBalancer configuration due to failed to resolve 2 qualified subnet for ALB. Subnets must contains these tags: 'kubernetes.io/cluster/m00nf1sh-dev': ['shared' or 'owned'] and 'kubernetes.io/role/elb': ['' or '1']. See https://kubernetes-sigs.github.io/aws-alb-ingress-controller/guide/controller/config/#subnet-auto-discovery for more details. Resolved qualified subnets: '[]'"
   

6. bug fix for pod readiness gate: capture 2 edge case that is not captured in original podReadinessGate PR

[jaypipes]

Is this something that is actionable, though? The message above doesn't seem to explain why this is a warning.

Maybe this should just be an INFO-level log message and perhaps change the message to something like "Ignoring targetGroup XXX during garbage collection because targetGroupARN is set, indicating it was not created by ALB Ingress Controller."?

[M00nF1sh]

Hi, jay, yes. This action is actionable. We issue this warning because we detected the targetGroup is created by the controller(based on tags), but user used ARN to reference it, which they shouldn't since we won't bind targets into it and won't manage the lifecycle.

It's stated in docs as well https://kubernetes-sigs.github.io/aws-alb-ingress-controller/guide/ingress/annotation/#actions "use ARN in forward Action".

[SaranBalaji90]

/approve
/lgtm

[k8s-ci-robot]

@SaranBalaji90: changing LGTM is restricted to collaborators

In response to this:

/approve
/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: M00nF1sh, SaranBalaji90

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [M00nF1sh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment