Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated golang version to 1.23.6 #715

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jkh52
Copy link
Contributor

@jkh52 jkh52 commented Feb 12, 2025

Build the server and agent binaries with 1.23.6.

Refresh golangci-lint.yaml.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 12, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jkh52

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 12, 2025
@jkh52
Copy link
Contributor Author

jkh52 commented Feb 12, 2025

/retest

@jkh52
Copy link
Contributor Author

jkh52 commented Feb 12, 2025

/assign @cheftako

PTAL, I wasn't sure if you had a specific reason to stop at 1.23.0, when there were minor versions available with fixes (https://go.dev/doc/devel/release#go1.23.0)

@jkh52
Copy link
Contributor Author

jkh52 commented Feb 19, 2025

/assign @tallclair

@cheftako
Copy link
Contributor

I think there are a few other places which need to change at the same time.
Eg.
https://github.com/kubernetes-sigs/apiserver-network-proxy/blob/master/.github/workflows/golangci-lint.yaml

@jkh52
Copy link
Contributor Author

jkh52 commented Feb 20, 2025

I think there are a few other places which need to change at the same time. Eg. https://github.com/kubernetes-sigs/apiserver-network-proxy/blob/master/.github/workflows/golangci-lint.yaml

I'm not sure that one is a problem, the logs in this PR for that lint step show it picking up 1.23.6. Opened #719 separately.

Do you see any other places missed?

- Use go 1.23.6
- Add release-0.32 branch (about to create)
@jkh52 jkh52 mentioned this pull request Feb 20, 2025
@jkh52
Copy link
Contributor Author

jkh52 commented Feb 20, 2025

PTAL, updated the golangci-lint.yaml

@jkh52
Copy link
Contributor Author

jkh52 commented Feb 26, 2025

Friendly ping.

It would be nice to include this in #707.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants