-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated golang version to 1.23.6 #715
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jkh52 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
/assign @cheftako PTAL, I wasn't sure if you had a specific reason to stop at 1.23.0, when there were minor versions available with fixes (https://go.dev/doc/devel/release#go1.23.0) |
/assign @tallclair |
I think there are a few other places which need to change at the same time. |
I'm not sure that one is a problem, the logs in this PR for that lint step show it picking up 1.23.6. Opened #719 separately. Do you see any other places missed? |
- Use go 1.23.6 - Add release-0.32 branch (about to create)
PTAL, updated the golangci-lint.yaml |
Friendly ping. It would be nice to include this in #707. |
Build the server and agent binaries with 1.23.6.
Refresh golangci-lint.yaml.