Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore uber-go/mock. #713

Merged
merged 1 commit into from
Feb 20, 2025
Merged

Conversation

jkh52
Copy link
Contributor

@jkh52 jkh52 commented Feb 12, 2025

Restore uber-go/mock, and make version in README.md consistent with go.mod.

(It looks like #546 was lost, likely inadvertently at #684.)

Includes steps:

# ensure correct tooling
go install go.uber.org/mock/mockgen@v0.5.0
go mod vendor
make mock_gen
go mod tidy

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 12, 2025
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Feb 12, 2025
@jkh52
Copy link
Contributor Author

jkh52 commented Feb 12, 2025

/assign @cheftako
/cc @liangyuanpeng

@k8s-ci-robot
Copy link
Contributor

@jkh52: GitHub didn't allow me to request PR reviews from the following users: liangyuanpeng.

Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/assign @cheftako
/cc @liangyuanpeng

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor

@liangyuanpeng liangyuanpeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 19, 2025
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 19, 2025
@jkh52
Copy link
Contributor Author

jkh52 commented Feb 19, 2025

@cheftako PTAL, thanks!

@jkh52
Copy link
Contributor Author

jkh52 commented Feb 19, 2025

/assign @tallclair

@cheftako
Copy link
Contributor

/lgtm
/approve

@tallclair
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 20, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheftako, jkh52

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit e8a3d17 into kubernetes-sigs:master Feb 20, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants