Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump kubernetes deps to v1.29.2. #565

Merged
merged 1 commit into from
Feb 24, 2024

Conversation

jkh52
Copy link
Contributor

@jkh52 jkh52 commented Feb 15, 2024

Catch up master branch to kubernetes v1.29.2. After this we can do similar in release-0.29 branch, for #562.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 15, 2024
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 15, 2024
@jkh52
Copy link
Contributor Author

jkh52 commented Feb 15, 2024

/retest

@jkh52
Copy link
Contributor Author

jkh52 commented Feb 16, 2024

Testing by hand, the below seems like a flake, but I worry could also be "more likely" with the newer grpc version and worth investigation.

--- FAIL: TestProxyDial_RequestCancelled_Concurrent_GRPC (32.82s)
    proxy_test.go:426: Agent connections leaked: 
        
        Diff:
        --- metric output does not match expectation; want
        +++ got:
        @@ -2,3 +2,3 @@
         # TYPE konnectivity_network_proxy_agent_open_endpoint_connections gauge
        -konnectivity_network_proxy_agent_open_endpoint_connections 0
        +konnectivity_network_proxy_agent_open_endpoint_connections 1
         
    proxy_test.go:429: found unexpected goroutines:
        [Goroutine 5753 in state IO wait, with internal/poll.runtime_pollWait on top of the stack:
        goroutine 5753 [IO wait]:
        internal/poll.runtime_pollWait(0x7f2348647fe0, 0x72)
        	/usr/local/go/src/runtime/netpoll.go:343 +0x85
        internal/poll.(*pollDesc).wait(0xc0001cca20, 0xc0005d7000?, 0x0)
        	/usr/local/go/src/internal/poll/fd_poll_runtime.go:84 +0xb1
        internal/poll.(*pollDesc).waitRead(...)

@jkh52
Copy link
Contributor Author

jkh52 commented Feb 16, 2024

/retest

@jkh52
Copy link
Contributor Author

jkh52 commented Feb 16, 2024

/assign @cheftako

@cheftako
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 24, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheftako, jkh52

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 7438a96 into kubernetes-sigs:master Feb 24, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants