This repository has been archived by the owner on Sep 24, 2021. It is now read-only.
Clean up verification tools #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chuckha The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
k8s-ci-robot
added
the
size/M
|
fixed! ptal @ashish-amarnath |
hack/verify-all.sh
Outdated
| set -o nounset | ||
| set -o pipefail | ||
|
|
||
| # shellcheck source=/dev/null | ||
| source "$(dirname "$0")/utils.sh" | ||
|
|
||
| # set REPO_PATH | ||
| readonly REPO_PATH=$(get_root_path) | ||
| REPO_PATH=$(get_root_path) |
There was a problem hiding this comment.
Suggested change
| REPO_PATH=$(get_root_path) | |
| readonly REPO_PATH=$(get_root_path) |
| @@ -117,6 +121,11 @@ if [[ "${res}" = 0 ]]; then | |||
| echo "All verify checks passed, congrats!" | |||
| else | |||
| echo "" | |||
There was a problem hiding this comment.
can this be removed?
There was a problem hiding this comment.
this is for aligning the output. It's nicer with it in.
Signed-off-by: Chuck Ha <chuckh@vmware.com>
Merged
|
/lgtm |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Chuck Ha chuckh@vmware.com
What this PR does / why we need it:
This PR cleans up the verify scripts to make the output tell us what failed in a clean way.