Fix panics #91
Fix panics #91
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chuckha The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
k8s-ci-robot
added
the
size/L
| makeManagementCluster(*managementClusterName, *version, *capdImage, *capiImage) | ||
| if err := setup.Parse(os.Args[2:]); err != nil { | ||
| fmt.Printf("%+v\n", err) | ||
| os.Exit(1) |
There was a problem hiding this comment.
i'm not actually sure why klog is in this file. If we need a logger we will use klogr. I'm going to play around with ripping out klog here and see why it exists in the first place.
|
@vincepri ah ha, i found a few more panics and set up a klogr to pass through the code and use it as a setup logger. |
Signed-off-by: Chuck Ha <chuckh@vmware.com>
|
yeah lots of repetition right now, if it becomes a problem we can solve it later |
|
/lgtm |
Signed-off-by: Chuck Ha chuckh@vmware.com
What this PR does / why we need it:
This PR removes the panic calls from capdctl
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #86
Special notes for your reviewer:
This also deletes some unused code simplifying
/assign @ashish-amarnath