Skip to content
This repository has been archived by the owner on Sep 24, 2021. It is now read-only.

Update capi base image and drop support for <v0.1.6 #85

Merged
merged 1 commit into from
Jul 15, 2019

Conversation

chuckha
Copy link
Contributor

@chuckha chuckha commented Jul 15, 2019

Signed-off-by: Chuck Ha chuckh@vmware.com

What this PR does / why we need it:
This PR drops support for CAPI < v0.1.6 as there was a panic in the node ref code that prevents these versions from working.

NONE

/hold

holding for testing
/cc @liztio

Signed-off-by: Chuck Ha <chuckh@vmware.com>
@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 15, 2019
@k8s-ci-robot k8s-ci-robot requested a review from liztio July 15, 2019 17:56
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 15, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chuckha

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 15, 2019
@chuckha
Copy link
Contributor Author

chuckha commented Jul 15, 2019

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 15, 2019
@liztio
Copy link
Contributor

liztio commented Jul 15, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 15, 2019
@k8s-ci-robot k8s-ci-robot merged commit bc3c292 into kubernetes-retired:master Jul 15, 2019
@chuckha chuckha deleted the capi-fix branch July 15, 2019 18:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants