Skip to content
This repository has been archived by the owner on Sep 24, 2021. It is now read-only.

Add a goimports verification #82

Merged
merged 3 commits into from
Jul 12, 2019
Merged

Add a goimports verification #82

merged 3 commits into from
Jul 12, 2019

Conversation

yuzhang17
Copy link
Contributor

What this PR does / why we need it:add a goimports verivication

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #78

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 10, 2019
@k8s-ci-robot k8s-ci-robot requested review from chuckha and justinsb July 10, 2019 21:34
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 10, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @EricZhang08. Thanks for your PR.

I'm waiting for a kubernetes-sigs or kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 10, 2019
@chuckha
Copy link
Contributor

chuckha commented Jul 10, 2019

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 10, 2019
@chuckha
Copy link
Contributor

chuckha commented Jul 10, 2019

hmm i wonder what failed. I need to update that script to show me which script failed.

/test pull-cluster-api-provider-docker-verify

@chuckha
Copy link
Contributor

chuckha commented Jul 10, 2019 •
edited
Loading

Oh, I bet you go imports is not available in the test build. @EricZhang08 could you add a line to install the command, much like the speller does as well?

As in, something like verify-spelling.sh

@yuzhang17
Copy link
Contributor Author

@chuckha ok, I am fixing it soon.

@yuzhang17 yuzhang17 force-pushed the add-goimports-verification branch from 7daa2ce to 987ed0f Compare July 11, 2019 19:49
@yuzhang17 yuzhang17 force-pushed the add-goimports-verification branch from 987ed0f to fc7db1e Compare July 11, 2019 19:50
ashish-amarnath
ashish-amarnath reviewed Jul 11, 2019
View reviewed changes
hack/verify-goimports.sh Outdated
# create a temporary directory
TMP_DIR=$(mktemp -d)

echo $TMP_DIR
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like leftovers from debugging.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.I forgot it.

@yuzhang17
Copy link
Contributor Author

/retest

@ashish-amarnath
Copy link
Contributor

/lgtm
/assign @chuckha

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 11, 2019
@ashish-amarnath
Copy link
Contributor

Thank you @EricZhang08 for getting this done! :)

@chuckha
Copy link
Contributor

chuckha commented Jul 12, 2019

/approve

thank you!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chuckha, ericzhang08

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 12, 2019
@k8s-ci-robot k8s-ci-robot merged commit a477868 into kubernetes-retired:master Jul 12, 2019
@yuzhang17 yuzhang17 mentioned this pull request Aug 13, 2019
Closed
6 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ashish-amarnath ashish-amarnath ashish-amarnath left review comments

@chuckha chuckha Awaiting requested review from chuckha

@justinsb justinsb Awaiting requested review from justinsb

Assignees

@chuckha chuckha

@ashish-amarnath ashish-amarnath

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add an imports verification
4 participants
@yuzhang17 @k8s-ci-robot @chuckha @ashish-amarnath