-
Notifications
You must be signed in to change notification settings - Fork 42
Conversation
Welcome @SharksZhang! |
Hi @SharksZhang. Thanks for your PR. I'm waiting for a kubernetes-sigs or kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @justinsb |
/ok-to-test |
/assign |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks fine, just one comment about running goimports
on the files with updated imports
kind/actions/kind.go
Outdated
@@ -24,6 +24,7 @@ import ( | |||
"os" | |||
"path/filepath" | |||
"regexp" | |||
constkind "sigs.k8s.io/cluster-api-provider-docker/kind/constants" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The imports are broken up into sections and alphabetized:
* first the standard library
* then all the non stdlib imports
please run goimports
over this file
/assign @chuckha |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
assigning amy for lgtm
/assign @amy
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chuckha, SharksZhang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
What this PR does / why we need it:We hardcode 6443 all over the place and it should be a constant
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #66
Special notes for your reviewer:
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
Release note: