This repository has been archived by the owner on Sep 24, 2021. It is now read-only.
Be flexible with versions #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chuck Ha <chuckh@vmware.com>
k8s-ci-robot
added
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chuckha The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
amy
reviewed
Jul 8, 2019
| @@ -291,6 +292,9 @@ func writeKubeConfig(n *nodes.Node, dest string, hostAddress string, hostPort in | |||
| } | |||
|
|
|||
| func image(version string) string { | |||
| if !strings.HasPrefix(version, "v") { | |||
| version = fmt.Sprintf("v%s", version) | |||
There was a problem hiding this comment.
its weird we're hardcoding the prefix with a v.
There was a problem hiding this comment.
Missed the !strings.HasPrefix(version, "v") part. If we're doing that verification, can we also do some sorta semver parameter checking.
Not a blocker.
There was a problem hiding this comment.
yeah, that's low on the priority list but would be good to make an issue for it
|
/lgtm |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Chuck Ha chuckh@vmware.com
What this PR does / why we need it:
We should be flexible with version numbers. v1.14.1? 1.14.1? whatever, it's all good
There is also a minor fix to be able to rename the management cluster.