Skip to content
This repository has been archived by the owner on Sep 24, 2021. It is now read-only.

update readme #25

Merged
merged 1 commit into from
Jun 26, 2019
Merged

update readme #25

merged 1 commit into from
Jun 26, 2019

Conversation

amy
Copy link
Contributor

@amy amy commented Jun 25, 2019 •
edited
Loading

Added a dependencies list and reformatted some of the README.
Related to: #19

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 25, 2019
@k8s-ci-robot k8s-ci-robot requested review from chuckha and vincepri June 25, 2019 21:58
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 25, 2019
@amy amy force-pushed the readme branch 3 times, most recently from ab0db9c to e8f501a Compare June 25, 2019 22:09
chuckha
chuckha reviewed Jun 25, 2019
View reviewed changes
Copy link
Contributor

@chuckha chuckha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for the update! just one issue with the numbers

@amy amy force-pushed the readme branch 3 times, most recently from b2ce2aa to b2b3ce9 Compare June 25, 2019 22:24
chuckha
chuckha approved these changes Jun 26, 2019
View reviewed changes
Copy link
Contributor

@chuckha chuckha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 26, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: amy, chuckha

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 26, 2019
@k8s-ci-robot k8s-ci-robot merged commit 9ff4e58 into kubernetes-retired:master Jun 26, 2019
@amy amy mentioned this pull request Jul 3, 2019
Closed
6 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chuckha chuckha chuckha approved these changes

@vincepri vincepri Awaiting requested review from vincepri

Assignees

@chuckha chuckha

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amy @k8s-ci-robot @chuckha