-
Notifications
You must be signed in to change notification settings - Fork 42
hack: include scripts for golint, gofmt, spelling, shellcheck, etc. #21
hack: include scripts for golint, gofmt, spelling, shellcheck, etc. #21
Conversation
3641808
to
7ec83c6
Compare
update: - deps: calls go mod tidy verify: - build: calls build for ./cmd - deps: verifies if the current go.* files are valid - gotest: calls go tests on _test files if present - govet: calls go vet - shellcheck: executes shellcheck on all .sh files
Currently supports .go, .py and .sh files.
7ec83c6
to
73d0491
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks legit.
One question, where does this code come from? Is there a repo where you're pulling this from or is it copy-pasta tribal knowledge?
|
I wonder if there's some way we could share these across similar applications 🤔 oh well, out of scope for this issue. /approve Thank you so much for this work 🙏 |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chuckha, neolit123 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
i though about that. instead of booking a standalone repo for we can technically have them hosted somewhere (e.g. under kubeadm) and a local, per-project script can wget them and run them on demand. problems are:
|
was #13, but i managed to corrupt the branch and the PR cannot be re-opened.
now also includes a commit for boilerplate checks.
WRT to presubmit PR verification:
xref #5
fixes #18
for kinder we have this that uses prow's pod-utils:
https://github.com/kubernetes/test-infra/blob/master/config/jobs/kubernetes/kubeadm/kubeadm-presubmits.yaml
similar can be done for kubernetes-sigs/cluster-api-provider-docker/presubmits.yaml
/kind feature
/priority important-soon
/assign @chuckha