Skip to content
This repository has been archived by the owner on Sep 24, 2021. It is now read-only.

Add CONTRIBUTING.md file #20

Merged
merged 1 commit into from
Jun 25, 2019
Merged

Add CONTRIBUTING.md file #20

merged 1 commit into from
Jun 25, 2019

Conversation

nikhita
Copy link
Member

@nikhita nikhita commented Jun 25, 2019

@k8s-ci-robot
Copy link
Contributor

Welcome @nikhita!

It looks like this is your first PR to kubernetes-sigs/cluster-api-provider-docker 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api-provider-docker has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 25, 2019
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 25, 2019
nikhita
nikhita commented Jun 25, 2019
View reviewed changes
CONTRIBUTING.md

## Contact Information

- [Slack channel](https://kubernetes.slack.com/messages/cluster-api)
Copy link
Member Author

@nikhita nikhita Jun 25, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Figured we could move to a capd specific channel later, after it's created (kubernetes/community#3836)

neolit123
neolit123 reviewed Jun 25, 2019
View reviewed changes
Copy link
Contributor

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 25, 2019
@chuckha
Copy link
Contributor

chuckha commented Jun 25, 2019

thank you !!

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chuckha, nikhita

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 25, 2019
@k8s-ci-robot k8s-ci-robot merged commit df91e19 into kubernetes-retired:master Jun 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@neolit123 neolit123 neolit123 left review comments

@justinsb justinsb Awaiting requested review from justinsb

@vincepri vincepri Awaiting requested review from vincepri

Assignees

@chuckha chuckha

@neolit123 neolit123

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nikhita @k8s-ci-robot @chuckha @neolit123