fix: update windows recording rules to remove duplicate entries for non running containers #840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on running containers
|
@arajkumar , @povilasv Please let me know if this fix looks good to you for merge. |
gracewehner
approved these changes
Apr 25, 2023
vishiy
approved these changes
Apr 25, 2023
Sohamdg081992
approved these changes
Apr 25, 2023
|
@arajkumar , @povilasv Let me know if you could help with merging this PR. |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For e.g. The following query returned a many to many matching error:
because there where multiple containers within the pod stuck in initizaling state and thus did not have container_id's set:
Hence our recording rule for them would fail. This fix eliminates those containers which are not running at all as there is no point in getting the cpu/memory usage for them.