Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bind to pod ips when env variable ENABLE_BIND_LOCAL_IP is set to true #5049

Merged
merged 5 commits into from
Mar 14, 2025
Merged

bind to pod ips when env variable ENABLE_BIND_LOCAL_IP is set to true #5049

merged 5 commits into from
Mar 14, 2025

Conversation

zhangzujian
Copy link
Member

@zhangzujian zhangzujian commented Mar 4, 2025 •
edited
Loading

Pull Request

What type of this PR

Examples of user facing changes:

  • Features
  • Bug fixes
  • Docs
  • Tests

Which issue(s) this PR fixes

Bind to the pod ips when we're running in a dual-stack cluster.

@coveralls
Copy link

coveralls commented Mar 4, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 13852232090

Details

  • 4 of 37 (10.81%) changed or added relevant lines in 4 files are covered.
  • 3 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.002%) to 22.014%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/daemon/config.go 0 1 0.0%
pkg/util/net.go 4 6 66.67%
pkg/daemon/gateway_linux.go 0 7 0.0%
pkg/daemon/tproxy_linux.go 0 23 0.0%
Files with Coverage Reduction New Missed Lines %
pkg/daemon/gateway_linux.go 1 0.0%
pkg/ovs/ovn-nb-logical_router_route.go 2 74.93%
Totals Coverage Status
Change from base Build 13850768820: 0.002%
Covered Lines: 10263
Relevant Lines: 46620
💛 - Coveralls

@zhangzujian zhangzujian changed the title bind to pod ip when env variable ENABLE_BIND_LOCAL_IP is set to true bind to pod ips when env variable ENABLE_BIND_LOCAL_IP is set to true Mar 13, 2025
@zhangzujian zhangzujian force-pushed the fix-bind-local-ip branch 4 times, most recently from c08f99b to cbb62ee Compare March 14, 2025 07:00
@zhangzujian
bind to pod ips when env variable ENABLE_BIND_LOCAL_IP is set to true
ffcb63a 
Signed-off-by: zhangzujian <zhangzujian.7@gmail.com>
@zhangzujian
fix e2e
1d24f1e 
Signed-off-by: zhangzujian <zhangzujian.7@gmail.com>
@zhangzujian
fix tproxy
3513561 
Signed-off-by: zhangzujian <zhangzujian.7@gmail.com>
@zhangzujian
fix lint
5b0a97b 
Signed-off-by: zhangzujian <zhangzujian.7@gmail.com>
@zhangzujian
fix e2e
1e92601 
Signed-off-by: zhangzujian <zhangzujian.7@gmail.com>
@zhangzujian zhangzujian marked this pull request as ready for review March 14, 2025 08:21
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. feature New network feature go Pull requests that update Go code test automation tests labels Mar 14, 2025
@zhangzujian zhangzujian requested a review from oilbeater March 14, 2025 08:31
@zhangzujian zhangzujian removed the feature New network feature label Mar 14, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Mar 14, 2025
@zhangzujian zhangzujian merged commit ba9bcec into kubeovn:master Mar 14, 2025
68 checks passed
@zhangzujian zhangzujian deleted the fix-bind-local-ip branch March 14, 2025 09:12
zhangzujian added a commit to zhangzujian/kube-ovn that referenced this pull request Mar 14, 2025
@zhangzujian
bind to pod ips when env variable ENABLE_BIND_LOCAL_IP is set to true (…
c248c0d 
…kubeovn#5049)

Signed-off-by: zhangzujian <zhangzujian.7@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oilbeater oilbeater

Assignees
No one assigned
Labels
go Pull requests that update Go code lgtm This PR has been approved by a maintainer need backport size:L This PR changes 100-499 lines, ignoring generated files. test automation tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zhangzujian @coveralls @oilbeater