Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simple vip lable update and then update subnet status #5036

Merged
merged 1 commit into from
Mar 4, 2025

Conversation

zbb88888
Copy link
Collaborator

@zbb88888 zbb88888 commented Feb 27, 2025

Pull Request

What type of this PR

Examples of user facing changes:

  • Bug fixes

image

image

make sure two label add just at the same time
make sure VIP CRD update trigger subnet status re-calcultate

Which issue(s) this PR fixes

Fixes #(issue-number)

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. bug Something isn't working labels Feb 27, 2025
@zbb88888 zbb88888 force-pushed the simple-vip-label-update branch from f69f773 to d70ac39 Compare February 27, 2025 02:48
@coveralls
Copy link

coveralls commented Feb 27, 2025

Pull Request Test Coverage Report for Build 13652312093

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 3 (0.0%) changed or added relevant lines in 1 file are covered.
  • 3 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.002%) to 22.061%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/controller/vip.go 0 3 0.0%
Files with Coverage Reduction New Missed Lines %
pkg/controller/vip.go 1 0.0%
pkg/ovs/ovn-nb-logical_router_route.go 2 74.93%
Totals Coverage Status
Change from base Build 13635614479: -0.002%
Covered Lines: 10261
Relevant Lines: 46512

💛 - Coveralls

@zbb88888 zbb88888 requested a review from oilbeater February 27, 2025 03:02
@zbb88888
Copy link
Collaborator Author

hi @oilbeater , would you please help review? thanks!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Mar 4, 2025
Signed-off-by: zbb88888 <jmdxjsjgcxy@gmail.com>
@zbb88888 zbb88888 force-pushed the simple-vip-label-update branch from d70ac39 to f2925b0 Compare March 4, 2025 11:07
@zbb88888 zbb88888 merged commit 6dfea74 into kubeovn:master Mar 4, 2025
9 of 10 checks passed
zbb88888 added a commit that referenced this pull request Mar 4, 2025
Signed-off-by: zbb88888 <jmdxjsjgcxy@gmail.com>
zbb88888 added a commit that referenced this pull request Mar 4, 2025
Signed-off-by: zbb88888 <jmdxjsjgcxy@gmail.com>
@zbb88888 zbb88888 deleted the simple-vip-label-update branch March 17, 2025 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants