Potential fix to #5028 #5031
Merged
Potential fix to #5028 #5031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:XS
zhangzujian
reviewed
Feb 27, 2025
zhangzujian
reviewed
Feb 27, 2025
pkg/controller/namespace.go
Outdated
| @@ -139,7 +139,11 @@ func (c *Controller) handleAddNamespace(key string) error { | |||
| // check if subnet is in custom vpc with configured defaultSubnet, then annotate the namespace with this subnet | |||
| if s.Spec.Vpc != "" && s.Spec.Vpc != c.config.ClusterRouter { | |||
| vpc, err := c.vpcsLister.Get(s.Spec.Vpc) | |||
| if err != nil { | |||
| if err == errors.IsNotFound(err) { | |||
| klog.Errorf("custom vpc is not found - %v", err) | |||
There was a problem hiding this comment.
Suggested change
| klog.Errorf("custom vpc is not found - %v", err) | |
| klog.Errorf("vpc %q is not found: %v", s.Spec.Vpc, err) |
zhangzujian
reviewed
Feb 27, 2025
Pull Request Test Coverage Report for Build 13764339336Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
|
@zbb88888 Any update on this? Can this be merged? |
|
The PR LGTM, @andrewlee1089 the DCO check failed, can you add signoff to your commit. |
andrewlee1089
force-pushed
the
alee/fix-namespace-issue
branch
from
c045cae to
b562f02
Compare
… cause new namespaces to never get correct annotations. Signed-off-by: Andrew Lee <alee@evroc.com>
andrewlee1089
force-pushed
the
alee/fix-namespace-issue
branch
from
b562f02 to
ad3b23f
Compare
|
@oilbeater - I've signed the DCO ! |
|
Thanks! @andrewlee1089 |
oilbeater
pushed a commit
that referenced
this pull request
Mar 13, 2025
…new namespaces to never get correct annotations. (#5031) Signed-off-by: Andrew Lee <alee@evroc.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
What type of this PR
Examples of user facing changes:
Which issue(s) this PR fixes
Fixes #(issue-number)