Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

controller: check condition NodeNetworkUnavailable when determining whether node is ready #4917

Merged
merged 1 commit into from
Jan 11, 2025
Merged

controller: check condition NodeNetworkUnavailable when determining whether node is ready #4917

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions pkg/controller/node.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,12 +41,16 @@ func (c *Controller) enqueueAddNode(obj interface{}) {
}

func nodeReady(node *v1.Node) bool {
for _, con := range node.Status.Conditions {
if con.Type == v1.NodeReady && con.Status == v1.ConditionTrue {
return true
var ready, networkUnavailable bool
for _, c := range node.Status.Conditions {
switch c.Type {
case v1.NodeReady:
ready = c.Status == v1.ConditionTrue
case v1.NodeNetworkUnavailable:
networkUnavailable = c.Status == v1.ConditionTrue
}
}
return false
return ready && !networkUnavailable
}

func (c *Controller) enqueueUpdateNode(oldObj, newObj interface{}) {
Expand Down
Loading