Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cni-server: set node NetworkUnavailable condition after join subnet gateway check #4915

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

zhangzujian
Copy link
Member

@zhangzujian zhangzujian commented Jan 9, 2025

Pull Request

What type of this PR

Examples of user facing changes:

  • Features
  • Bug fixes
  • Docs
  • Tests

Which issue(s) this PR fixes

https://kubernetes.io/docs/reference/node/node-status/#condition

…ateway check

Signed-off-by: zhangzujian <zhangzujian.7@gmail.com>
@coveralls
Copy link

coveralls commented Jan 9, 2025

Pull Request Test Coverage Report for Build 12685208356

Details

  • 0 of 57 (0.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.02%) to 22.059%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/daemon/init.go 0 1 0.0%
pkg/util/k8s.go 0 24 0.0%
pkg/daemon/ovs_linux.go 0 32 0.0%
Totals Coverage Status
Change from base Build 12674528419: -0.02%
Covered Lines: 10166
Relevant Lines: 46086

💛 - Coveralls

@zhangzujian zhangzujian marked this pull request as ready for review January 9, 2025 07:30
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Jan 9, 2025
@dosubot dosubot bot added the go Pull requests that update Go code label Jan 9, 2025
@zhangzujian zhangzujian requested a review from oilbeater January 9, 2025 08:42
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 9, 2025
@zhangzujian zhangzujian merged commit e250afa into kubeovn:master Jan 9, 2025
67 checks passed
@zhangzujian zhangzujian deleted the node-condition branch January 9, 2025 10:04
zhangzujian added a commit to zhangzujian/kube-ovn that referenced this pull request Jan 9, 2025
…ateway check (kubeovn#4915)

Signed-off-by: zhangzujian <zhangzujian.7@gmail.com>
zhangzujian added a commit to zhangzujian/kube-ovn that referenced this pull request Jan 9, 2025
…ateway check (kubeovn#4915)

Signed-off-by: zhangzujian <zhangzujian.7@gmail.com>
zhangzujian added a commit to zhangzujian/kube-ovn that referenced this pull request Jan 10, 2025
…ateway check (kubeovn#4915)

Signed-off-by: zhangzujian <zhangzujian.7@gmail.com>
zhangzujian added a commit to zhangzujian/kube-ovn that referenced this pull request Jan 10, 2025
…ateway check (kubeovn#4915)

Signed-off-by: zhangzujian <zhangzujian.7@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go Pull requests that update Go code lgtm This PR has been approved by a maintainer need backport size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants