Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubectl ko performance enhance (#2975) #2992

Merged
merged 1 commit into from
Jun 29, 2023

Conversation

changluyi
Copy link
Collaborator

@changluyi changluyi commented Jun 29, 2023

  • kubectl ko performance enhance
  1. add result format
  2. add gc
  3. add svc performance test
  4. add diagnose to node port

What type of this PR

Examples of user facing changes:

  • Features
  • Bug fixes
  • Docs
  • Tests

Which issue(s) this PR fixes:

Fixes #(issue-number)

WHAT

🤖 Generated by Copilot at 57beabd

This pull request enhances the pinger tool and package to support custom target IP and port pairs for connectivity check. It adds a new flag --target-ip-ports to the tool and modifies the pinger package to handle it. It also fixes some minor typos in the logs.

🤖 Generated by Copilot at 57beabd

pinger can test
multiple IP and ports
autumn of typos

HOW

🤖 Generated by Copilot at 57beabd

  • Add a new field TargetIPPorts to the Configuration struct and a new flag --target-ip-ports to the ParseFlags function to store and parse the user-specified target protocol, IP and port for connectivity check (link, link, link)
  • Implement a new function checkAccessTargetIPPorts in ping.go to perform the connectivity check for the target protocol, IP and port using the TCPConnectivityCheck or UDPConnectivityCheck function from the util package, and log the result or error of each check (link)
  • Call the checkAccessTargetIPPorts function from the ping function if the TargetIPPorts field is not empty, and set the errHappens variable to true if the function returns an error (link)
  • Fix typos in the log messages of the pingNodes and pingPods functions, changing "connnectivity" to "connectivity" (link, link)
  • Import the kubeovnv1 package in ping.go to use the constants and types for the kube-ovn API, such as ProtocolIPv6 (link)

Sorry, something went wrong.

 * kubectl ko performance enhance
 1. add result format
 2. add gc
 3. add svc performance test
 4. add diagnose to node port
@changluyi changluyi merged commit 1c9fc6a into release-1.9 Jun 29, 2023
@changluyi changluyi deleted the kubectl_ko_perf_enhance_release-1.9 branch June 29, 2023 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant