Skip to content

check requests of kf components using GHA #3091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

milinddethe15
Copy link
Member

@milinddethe15 milinddethe15 commented Apr 9, 2025

Pull Request Template for Kubeflow Manifests

✏️ Summary of Changes

Describe the changes you have made, including any refactoring or feature additions.

with this PR I'm trying to run the kubeflow ecosytem on ubuntu-latest-16-cores runner (instead of using my local cluster) and checking the resources consumption of components by modifying the full_kubeflow_integration_test to just deploy the components (I removed the tests to get minimum usage of pods) and read the usage using metrics-server.
We aren't merging this PR.

cc @juliusvonkohout for /ok-to-test

📦 Dependencies

List any dependencies or related PRs (e.g., "Depends on #123").

🐛 Related Issues

Link any issues that are resolved or affected by this PR.

#3083

✅ Contributor Checklist


You can join the CNCF Slack and access our meetings at the Kubeflow Community website. Our channel on the CNCF Slack is here #kubeflow-platform.

Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kimwnasptd for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@milinddethe15 milinddethe15 changed the title Update full_kubeflow_integration_test.yaml check requests of kf components using GHA Apr 9, 2025
@milinddethe15 milinddethe15 mentioned this pull request Apr 9, 2025
7 tasks
@juliusvonkohout
Copy link
Member

Please use always rebase in the future instead of the merge from master as you did.

@juliusvonkohout
Copy link
Member

juliusvonkohout commented Apr 9, 2025

Probably its best to create a new fresh PR from scratch and not use merge from master in the future, because i think it messes up files and commit history

@milinddethe15 milinddethe15 force-pushed the patch-1 branch 2 times, most recently from b6d428e to 08a5410 Compare April 12, 2025 14:39
@google-oss-prow google-oss-prow bot added size/S and removed size/M labels Apr 12, 2025
@milinddethe15
Copy link
Member Author

Probably its best to create a new fresh PR from scratch and not use merge from master in the future, because i think it messes up files and commit history

I have fixed the commits in this PR itself. Now, I will add the components' resource usage table in README

@juliusvonkohout juliusvonkohout marked this pull request as ready for review April 14, 2025 08:45
@juliusvonkohout juliusvonkohout linked an issue Apr 14, 2025 that may be closed by this pull request
7 tasks
@google-oss-prow google-oss-prow bot added size/XXL and removed size/S labels Apr 27, 2025
Signed-off-by: milinddethe15 <milinddethe15@gmail.com>
Signed-off-by: milinddethe15 <milinddethe15@gmail.com>
@juliusvonkohout
Copy link
Member

juliusvonkohout commented Apr 27, 2025

That looks good. Now we just need to generate the markdown table at the end with the maximum of actual usage and requests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Requests documentation
2 participants