Skip to content
This repository has been archived by the owner on Aug 17, 2023. It is now read-only.

Automated cherry pick of #438: fail build on missing application name #446

Conversation

Jeffwan
Copy link
Member

@Jeffwan Jeffwan commented Nov 15, 2020

No description provided.

@google-cla
Copy link

google-cla bot commented Nov 15, 2020

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@Jeffwan Jeffwan changed the title Automated cherry pick of #438: fail build on missing application name Cherry pick of #438 on v1.2-branch. #438: fail build on missing application name For details on the cherry pick process, see the [cherry pick requests](https://git.k8s.io/community/contributors/devel/sig-release/cherry-picks.md) page. Automated cherry pick of #438: fail build on missing application name Nov 15, 2020
@Jeffwan Jeffwan force-pushed the automated-cherry-pick-of-#438-upstream-v1.2-branch branch from 3b68669 to fb9645f Compare November 15, 2020 18:23
@google-cla
Copy link

google-cla bot commented Nov 15, 2020

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@Jeffwan
Copy link
Member Author

Jeffwan commented Nov 15, 2020

@googlebot I consent.

@google-cla
Copy link

google-cla bot commented Nov 15, 2020

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@Jeffwan Jeffwan force-pushed the automated-cherry-pick-of-#438-upstream-v1.2-branch branch from fb9645f to a6cec0d Compare November 15, 2020 18:24
@Jeffwan
Copy link
Member Author

Jeffwan commented Nov 15, 2020

/cc @PatrickXYS

@PatrickXYS
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jeffwan, PatrickXYS

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Jeffwan
Copy link
Member Author

Jeffwan commented Nov 15, 2020

@PatrickXYS Can you leave lgtm. I can not lgtm myself

@PatrickXYS
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot merged commit cc8fea5 into kubeflow:v1.2-branch Nov 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants