-
Notifications
You must be signed in to change notification settings - Fork 756
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
recomment using kustomize v2.0.3 for mnist #584
recomment using kustomize v2.0.3 for mnist #584
Conversation
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jlewi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
Tested failed due to
Seems the TFJob is upgraded in the test cluster? will confirm later. |
bca8d26
to
d150259
Compare
That's stange, checked the code, the version v1beta2 of TFJob should exist in the cluster, check some code to show the TFJob version for debug... Thanks. |
From the debug information, the tfjobs is not installed in the testing cluster. As below error:
@jlewi Do you know what's changed in the testing cluster? Anyone can help to check/fix this? Thanks. |
What cluster are you using? |
I checked v-kfmaster-n01 See attached Its v1. |
Opened #588 to give you access to the clusters. |
d150259
to
e7fb7a5
Compare
e7fb7a5
to
1993b49
Compare
@jlewi Many thanks. Yes, that works fine with the cluster! |
/lgtm |
@aginpatrick kustomize should have no implications with kubectl version. But kustomize has been intergrated in the kubectl, see https://kubernetes.io/blog/2019/03/25/kubernetes-1-14-release-announcement/. kustomize v2.0.3 is available in kubectl v1.15. |
Recently someones hit one problem while running mnist example with new kustomize (v2.1.0), such as #583 and #578, after checked the problem, I think that's should be a issue in new kustomize, logged ticket to trace in kustomize.
But avoid user stepping on the pit, the PR is to add note to recomment user to use kustomize 2.0.3. May enhance later if the kustomzie issue fixed.
fixes: #583 #578
This change is