Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

recomment using kustomize v2.0.3 for mnist #584

Merged
merged 1 commit into from
Jul 5, 2019

Conversation

jinchihe
Copy link
Member

@jinchihe jinchihe commented Jul 2, 2019

Recently someones hit one problem while running mnist example with new kustomize (v2.1.0), such as #583 and #578, after checked the problem, I think that's should be a issue in new kustomize, logged ticket to trace in kustomize.

But avoid user stepping on the pit, the PR is to add note to recomment user to use kustomize 2.0.3. May enhance later if the kustomzie issue fixed.

fixes: #583 #578


This change is Reviewable

@jlewi
Copy link
Contributor

jlewi commented Jul 2, 2019

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jlewi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jinchihe
Copy link
Member Author

jinchihe commented Jul 2, 2019

/retest

@jinchihe
Copy link
Member Author

jinchihe commented Jul 2, 2019

Tested failed due to

error: unable to recognize "STDIN": no matches for kind "TFJob" in version "kubeflow.org/v1beta2

Seems the TFJob is upgraded in the test cluster? will confirm later.

@jinchihe jinchihe force-pushed the remind_kustomize_version branch from bca8d26 to d150259 Compare July 3, 2019 01:03
@k8s-ci-robot k8s-ci-robot removed the lgtm label Jul 3, 2019
@jinchihe
Copy link
Member Author

jinchihe commented Jul 3, 2019

That's stange, checked the code, the version v1beta2 of TFJob should exist in the cluster, check some code to show the TFJob version for debug... Thanks.

@jinchihe
Copy link
Member Author

jinchihe commented Jul 3, 2019

From the debug information, the tfjobs is not installed in the testing cluster. As below error:

Error from server (NotFound): customresourcedefinitions.apiextensions.k8s.io “tfjobs.kubeflow.org” not found

@jlewi Do you know what's changed in the testing cluster? Anyone can help to check/fix this? Thanks.

@jlewi
Copy link
Contributor

jlewi commented Jul 4, 2019

What cluster are you using?
Is it kf-vmaster-XX
Those clusters are now deploying from master which might be using TFJob v1.

@jlewi
Copy link
Contributor

jlewi commented Jul 4, 2019

I checked v-kfmaster-n01
and it looks like TFJob is defined.

See attached
tfjob.yaml.txt

Its v1.

@jlewi
Copy link
Contributor

jlewi commented Jul 4, 2019

Opened #588 to give you access to the clusters.

@jinchihe jinchihe force-pushed the remind_kustomize_version branch from d150259 to e7fb7a5 Compare July 5, 2019 01:02
@jinchihe jinchihe force-pushed the remind_kustomize_version branch from e7fb7a5 to 1993b49 Compare July 5, 2019 01:19
@jinchihe
Copy link
Member Author

jinchihe commented Jul 5, 2019

@jlewi Many thanks. Yes, that works fine with the cluster!

@hougangliu
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot merged commit 871895c into kubeflow:master Jul 5, 2019
@jinchihe jinchihe deleted the remind_kustomize_version branch July 5, 2019 02:20
@aginpatrick
Copy link

@jinchihe @jlewi would it be useful to add that kustomize v2 blocks relative paths (it's no more true with v3). So kustomization.yaml cannot contain "resources: -../bases" for example. I think that substitute resources for bases is the solution in this case.

@aginpatrick
Copy link

@jinchihe @jlewi btw, does using kustomize v2.0.3 has implications for kubectl version? I mean, is v2.0.3 compatible with latest kubectl or one has to use older version?

@jinchihe
Copy link
Member Author

jinchihe commented Jul 8, 2019

@aginpatrick kustomize should have no implications with kubectl version. But kustomize has been intergrated in the kubectl, see https://kubernetes.io/blog/2019/03/25/kubernetes-1-14-release-announcement/. kustomize v2.0.3 is available in kubectl v1.15.

dsdinter pushed a commit to dsdinter/examples that referenced this pull request Jul 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[codelab-intro-mnist-feedback]:
5 participants