UI: Improve TransportModeChip text contrast accessibility #611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
ksharma-xyz
force-pushed
the
02-13-text_color_for_chip
branch
from
9355c98 to
819e7cb
Compare
ksharma-xyz
changed the title
ksharma-xyz
changed the base branch from
02-12-prefer_param_color_and_then_localcomposition_color
to
graphite-base/611
ksharma-xyz
force-pushed
the
02-13-text_color_for_chip
branch
from
819e7cb to
3d9ac8c
Compare
ksharma-xyz
force-pushed
the
graphite-base/611
branch
from
3251804 to
5018501
Compare
ksharma-xyz
force-pushed
the
02-13-text_color_for_chip
branch
from
3d9ac8c to
927c012
Compare
Merge activity
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Enhanced color contrast handling for transport mode chips to ensure better accessibility
What changed?
getForegroundColorfunction to accept an optional foreground color parameterTransportModeChipcomponentHow to test?
Why make this change?
To improve accessibility by ensuring text remains readable across all transport mode chips, regardless of their background color. This change follows WCAG AA guidelines for text contrast ratios, making the app more accessible to users with visual impairments.