Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tslint:recommended appears to not be working #9

Closed
Turbo87 opened this issue Jan 8, 2017 · 5 comments
Closed

tslint:recommended appears to not be working #9

Turbo87 opened this issue Jan 8, 2017 · 5 comments

Comments

@Turbo87
Copy link

Turbo87 commented Jan 8, 2017

My tslint.json file is looking like this:

{
  "extends": "tslint:recommended"
}

and seems to be supported properly when I run it via command line (node_modules/.bin/tslint src/*.ts).


If I try to use the same file with broccoli-tslinter I'm seeing the following error:

The format of the config file is { rules: { /* rules list */ } }, where /* rules list */ is a key: value comma-seperated list of rulename: rule-options pairs.

If I change the file to:

{
  "extends": "tslint:recommended",
  "rules": {
  }
}

I'm now seeing:

Using tslint.json as the default file for linting rules
No rules defined for linting

but I don't see all the errors that I see when running directly from the command line.

Any clue what's going on here?

@kratiahuja
Copy link
Owner

Hmm nothing drops in from the top of my head. Will need dig deeper. Will look at it and let you know by EOD . Thanks for reporting @Turbo87

@kratiahuja
Copy link
Owner

kratiahuja commented Jan 9, 2017

@Turbo87 : Found the issue. The core issue is that TSLint library lint API does not take into consideration extends yet. The extends API seems to be only implemented in tslint-cli per this PR. I will open an issue in the TSLint repo.

In the meanwhile I will also remove the extra checks for rules in this plugin since tslint checks for it now. However, until the issue in tslint is not fixed, you will not be able to use it via the broccoli plugin 😞 .

I will try to fix the issue in tslint repo but I won't be able to start looking at it until next weekend.

@kratiahuja
Copy link
Owner

Opened issue in tslint: palantir/tslint#2011

@Turbo87
Copy link
Author

Turbo87 commented Jan 9, 2017

@kratiahuja awesome, thanks for taking care of this so quickly!

@Turbo87
Copy link
Author

Turbo87 commented Jan 26, 2017

fixed by #12. thanks again!

@Turbo87 Turbo87 closed this as completed Jan 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants