Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removes cargo_sqlx and cargo_deb tasks #319

Merged
merged 3 commits into from
Feb 5, 2025
Merged

Removes cargo_sqlx and cargo_deb tasks #319

merged 3 commits into from
Feb 5, 2025

Conversation

Tpt
Copy link
Contributor

@Tpt Tpt commented Feb 4, 2025

Unused internally and on GitHub

@Tpt
Removes cargo_sqlx and cargo_deb tasks
51eed20 
Unused internally and on GitHub
@Tpt Tpt force-pushed the tpt/sqlx-remove branch from 0ea41db to 51eed20 Compare February 4, 2025 17:43
@Tpt Tpt marked this pull request as ready for review February 5, 2025 07:27
vsiles
vsiles approved these changes Feb 5, 2025
View reviewed changes
Copy link
Contributor

@vsiles vsiles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not against cleanup, but can we give a motivation for that move in the description ? (like "we no longer/never used it" ?

@Tpt
Copy link
Contributor Author

Tpt commented Feb 5, 2025

Not against cleanup, but can we give a motivation for that move in the description ? (like "we no longer/never used it" ?

Done! I don't think it got actually used anywhere and code search does not yield anything now

@Tpt Tpt enabled auto-merge (squash) February 5, 2025 19:22
@Tpt Tpt merged commit 7d3ed19 into develop Feb 5, 2025
15 checks passed
@Tpt Tpt deleted the tpt/sqlx-remove branch February 5, 2025 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srstevenson srstevenson srstevenson approved these changes

@vsiles vsiles vsiles approved these changes

@antoinebrl antoinebrl antoinebrl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Kraken
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Tpt @srstevenson @vsiles @antoinebrl