Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move version bump logic into publish task #196

Conversation

Colin1860
Copy link
Contributor

Since bumping versions is only really necessary when publishing the affected logic is moved into the publish task and the dedicated bump-task removed

@Colin1860 Colin1860 force-pushed the cmikolajczak/move_bump_into_publish branch from fec95a5 to 0f6f8fc Compare February 13, 2024 13:42
@Colin1860 Colin1860 marked this pull request as ready for review February 13, 2024 13:46
Copy link
Contributor

@NiklasRosenstein NiklasRosenstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me overall! :)

@Colin1860 Colin1860 force-pushed the cmikolajczak/move_bump_into_publish branch from 0f6f8fc to db9339f Compare February 15, 2024 14:19
Since bumping versions is only really necessary when publishing
the affected logic is moved into the publish task and the
dedicated bump-task removed
@Colin1860 Colin1860 force-pushed the cmikolajczak/move_bump_into_publish branch from db9339f to c6ed82f Compare February 16, 2024 07:01
@Colin1860 Colin1860 force-pushed the cmikolajczak/move_bump_into_publish branch from c6ed82f to 0a78512 Compare February 16, 2024 13:53
@NiklasRosenstein NiklasRosenstein enabled auto-merge (squash) February 27, 2024 12:26
@NiklasRosenstein NiklasRosenstein merged commit bfdd906 into kraken-build:develop Feb 27, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants