Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix transaction on DB-API 2.0 #21

Merged
merged 1 commit into from
Oct 11, 2019
Merged

fix transaction on DB-API 2.0 #21

merged 1 commit into from
Oct 11, 2019

Conversation

koxudaxi
Copy link
Owner

The PR fixes transaction on DB-API 2.0.
The Client begins a transaction when calling cursor().

@codecov
Copy link

codecov bot commented Oct 11, 2019

Codecov Report

Merging #21 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #21   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           4      4           
  Lines         397    399    +2     
  Branches       47     48    +1     
=====================================
+ Hits          397    399    +2
Impacted Files Coverage Δ
pydataapi/dbapi.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2dbd764...33edc3b. Read the comment docs.

@koxudaxi koxudaxi merged commit bf36fcb into master Oct 11, 2019
@koxudaxi koxudaxi deleted the fix_dbapi_transaction branch October 11, 2019 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant