Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metrics missing tags fixed #163

Merged
merged 6 commits into from
Nov 5, 2024
Merged

Conversation

GoodforGod
Copy link
Contributor

@GoodforGod GoodforGod commented Oct 28, 2024

Micrometer missing/optional tags as empty string by default if missing to avoid metric collision when reporting by micrometer different tag set for same metric

@GoodforGod GoodforGod added this to the v1.1.12 milestone Oct 28, 2024
@GoodforGod GoodforGod requested review from Squiry and eld0727 October 28, 2024 10:33
@GoodforGod GoodforGod added bug Something isn't working module: telemetry Related to Telemetry module labels Oct 28, 2024
Copy link

github-actions bot commented Oct 28, 2024

Test Results

985 tests   985 ✅  2m 33s ⏱️
125 suites    0 💤
125 files      0 ❌

Results for commit fcdfdbd.

♻️ This comment has been updated with latest results.

@GoodforGod GoodforGod force-pushed the bugfix/metrics-missing-tags branch from 5ebf5d4 to f46ffe6 Compare October 29, 2024 19:03
@GoodforGod GoodforGod force-pushed the bugfix/metrics-missing-tags branch from 00a8a2c to fcdfdbd Compare November 5, 2024 13:45
@GoodforGod GoodforGod merged commit e21ddc9 into master Nov 5, 2024
9 checks passed
@GoodforGod GoodforGod deleted the bugfix/metrics-missing-tags branch November 5, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working module: telemetry Related to Telemetry module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant