Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koordlet: fix podresources not found #2344

Merged
merged 1 commit into from
Feb 21, 2025

Conversation

ZiMengSheng
Copy link
Contributor

@ZiMengSheng ZiMengSheng commented Feb 21, 2025

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

image

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

Copy link

codecov bot commented Feb 21, 2025

Codecov Report

Attention: Patch coverage is 81.81818% with 2 lines in your changes missing coverage. Please review.

Project coverage is 65.93%. Comparing base (af357ca) to head (aead7c5).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ordlet/statesinformer/impl/states_pod_resources.go 81.81% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2344      +/-   ##
==========================================
- Coverage   65.94%   65.93%   -0.01%     
==========================================
  Files         466      466              
  Lines       54879    54885       +6     
==========================================
  Hits        36191    36191              
- Misses      16074    16078       +4     
- Partials     2614     2616       +2     
Flag Coverage Δ
unittests 65.93% <81.81%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ZiMengSheng ZiMengSheng force-pushed the fixpodresources branch 4 times, most recently from eca3caf to 2795a33 Compare February 21, 2025 04:18
Signed-off-by: wangjianyu.wjy <wangjianyu.wjy@alibaba-inc.com>
Copy link
Member

@saintube saintube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@saintube saintube added the lgtm label Feb 21, 2025
@koordinator-bot koordinator-bot bot merged commit b95a9bf into koordinator-sh:main Feb 21, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants