-
Notifications
You must be signed in to change notification settings - Fork 343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
webhook: support elasticquota enable update resource key #2323
webhook: support elasticquota enable update resource key #2323
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2323 +/- ##
==========================================
- Coverage 66.09% 66.05% -0.05%
==========================================
Files 458 461 +3
Lines 54197 54610 +413
==========================================
+ Hits 35823 36071 +248
- Misses 15801 15928 +127
- Partials 2573 2611 +38
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
01bf3f6
to
081511d
Compare
group_quota_manager.go里面的UpdateQuota、RefreshRuntime 需要加单侧覆盖这种情况 |
081511d
to
3a72f52
Compare
added |
3a72f52
to
f44afa6
Compare
f44afa6
to
83ca151
Compare
Signed-off-by: lijunxin <lijunxin.ljx@alibaba-inc.com>
83ca151
to
222da91
Compare
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job! @lijunxin559
Ⅰ. Describe what this PR does
Currently, the consistency check for resource types in elastic quota's add, delete and update is insufficient and too rigid. For example, maxResourceKey requires parent-child consistency, which can lead to the following problems:
However, considering the original intention of quota design and current computing logic, it does not affect related calculations while supporting resource type checks(also already added more unitTest cases). Among them:
Ⅱ. Does this pull request fix one issue?
I propose to add a feature called ElasticQuotaEnableUpdateResourceKey to support changes to ElasticQuota Resource Key, with the following modifications:
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test