Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scheduler: fix ReplaceQuotas ut #2318

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

shaloulcy
Copy link
Contributor

Ⅰ. Describe what this PR does

scheduler: fix ReplaceQuotas ut

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

Copy link

codecov bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.08%. Comparing base (8d0e6ce) to head (7979414).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2318      +/-   ##
==========================================
+ Coverage   66.07%   66.08%   +0.01%     
==========================================
  Files         458      458              
  Lines       54145    54182      +37     
==========================================
+ Hits        35774    35807      +33     
  Misses      15802    15802              
- Partials     2569     2573       +4     
Flag Coverage Δ
unittests 66.08% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@saintube saintube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ZiMengSheng
Copy link
Contributor

/approve

@ZiMengSheng ZiMengSheng self-requested a review January 13, 2025 02:33
Signed-off-by: shaloulcy <lcy041536@gmail.com>
@ZiMengSheng ZiMengSheng enabled auto-merge (rebase) January 13, 2025 07:16
@koordinator-bot koordinator-bot bot merged commit 07c81e2 into koordinator-sh:main Jan 13, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants