Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scheduler: make error more clear when numa-aware #2305

Merged
merged 1 commit into from
Dec 26, 2024

Conversation

ZiMengSheng
Copy link
Contributor

@ZiMengSheng ZiMengSheng commented Dec 25, 2024

Ⅰ. Describe what this PR does

optimize NUMA Affinity Error, give which resource is unsatisfied

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

Copy link

codecov bot commented Dec 25, 2024

Codecov Report

Attention: Patch coverage is 74.48980% with 25 lines in your changes missing coverage. Please review.

Project coverage is 66.04%. Comparing base (a62dd49) to head (6eb0371).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
.../scheduler/frameworkext/topologymanager/manager.go 0.00% 21 Missing ⚠️
...g/scheduler/frameworkext/topologymanager/policy.go 94.44% 1 Missing and 1 partial ⚠️
pkg/scheduler/plugins/deviceshare/topology_hint.go 85.71% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2305      +/-   ##
==========================================
+ Coverage   66.02%   66.04%   +0.02%     
==========================================
  Files         458      458              
  Lines       53868    53921      +53     
==========================================
+ Hits        35564    35611      +47     
- Misses      15749    15756       +7     
+ Partials     2555     2554       -1     
Flag Coverage Δ
unittests 66.04% <74.48%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: wangjianyu.wjy <wangjianyu.wjy@alibaba-inc.com>
@ZiMengSheng ZiMengSheng changed the title scheduler: expose reasons when no possible numa hint scheduler: make error more clear when numa-aware Dec 26, 2024
Copy link
Member

@saintube saintube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@saintube saintube added the lgtm label Dec 26, 2024
@koordinator-bot koordinator-bot bot merged commit e49c43d into koordinator-sh:main Dec 26, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants