koord-manager: refactor oversale resource calculate logic. #2240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2240 +/- ##
==========================================
- Coverage 66.31% 65.97% -0.35%
==========================================
Files 453 453
Lines 53327 53323 -4
==========================================
- Hits 35364 35178 -186
- Misses 15413 15609 +196
+ Partials 2550 2536 -14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@saintube PTAL thanks. |
saintube
requested review from
hormes,
zwzhang0107,
saintube and
jasonliu747
and removed request for
zwzhang0107
saintube
reviewed
Nov 1, 2024
tan90github
force-pushed
the
refactor/change-res-logic
branch
from
2513944 to
387b207
Compare
|
/lgtm |
…ate logic. Signed-off-by: wangyang60 <wangy9834@163.com>
Signed-off-by: wangyang60 <wangy9834@163.com>
tan90github
force-pushed
the
refactor/change-res-logic
branch
from
387b207 to
fcf0593
Compare
|
/approve |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR does
In order to better support mid resource in the future, we refactored the reporting code for oversale resources and extracted the public functions that mid resources and batch resources may use.
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test