Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

util: add defaulting to blkio qos to improve robustness #2238

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

zqzten
Copy link
Member

@zqzten zqzten commented Oct 25, 2024

Ⅰ. Describe what this PR does

We've found a case that if we configure the resource qos config to ..."cgroupRoot":{"blkioQOS":{}}..., koordlet would crash due to a NPE panic in blkio reconcile.

This PR add the previously missing defaulting to blkio qos to solve this issue.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

Signed-off-by: Zach Zhu <zzqshu@126.com>
Copy link

codecov bot commented Oct 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.31%. Comparing base (3963c04) to head (c91dd24).
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2238      +/-   ##
==========================================
+ Coverage   66.28%   66.31%   +0.03%     
==========================================
  Files         453      453              
  Lines       53176    53214      +38     
==========================================
+ Hits        35248    35290      +42     
+ Misses      15390    15384       -6     
- Partials     2538     2540       +2     
Flag Coverage Δ
unittests 66.31% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@saintube saintube requested review from saintube and zwzhang0107 and removed request for saintube October 25, 2024 13:49
@saintube
Copy link
Member

/lgtm
/cc @zwzhang0107

@saintube saintube added the lgtm label Oct 25, 2024
@koordinator-bot koordinator-bot bot merged commit 949aa79 into koordinator-sh:main Nov 5, 2024
22 checks passed
@zqzten zqzten deleted the defaulting branch November 5, 2024 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants