Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scheduler: consider pod requests when gpu&RDMA joint allocate #2233

Merged

Conversation

ZiMengSheng
Copy link
Contributor

@ZiMengSheng ZiMengSheng commented Oct 24, 2024

Ⅰ. Describe what this PR does

a node with two numaNode, two pcie per numaNode, two gpu and two rdma per pcie, user may want two gpu and two rdma by following protocol

apiVersion: v1
kind: Pod
metadata:
  name: hello-gpu
  namespace: default
  annotations:
    # 表示分走 deviceTypes[0] 之后会尝试在同 PCIE 继续分配 deviceTypes[1]、deviceTypes[2]、...
    scheduling.koordinator.sh/device-joint-allocate:|
      {
        "deviceTypes": [
            "gpu",
            "rdma"
        ]
      }
spec:
  containers:
  - resources:
      limits:
        cpu: "16"
        memory: 32Gi
        nvidia.com/gpu: "2"
        koordinator.sh/rdma: "200"
      requests:
        cpu: "16"
        memory: 32Gi
        nvidia.com/gpu: "2"
        koordinator.sh/rdma: "200"

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

Signed-off-by: wangjianyu.wjy <wangjianyu.wjy@alibaba-inc.com>
Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.29%. Comparing base (63f9c72) to head (73d8080).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2233   +/-   ##
=======================================
  Coverage   66.29%   66.29%           
=======================================
  Files         453      453           
  Lines       53175    53175           
=======================================
+ Hits        35250    35255    +5     
+ Misses      15389    15382    -7     
- Partials     2536     2538    +2     
Flag Coverage Δ
unittests 66.29% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@songtao98
Copy link
Contributor

/lgtm

Copy link
Member

@jasonliu747 jasonliu747 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@koordinator-bot koordinator-bot bot merged commit 3963c04 into koordinator-sh:main Oct 24, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants