Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scheduler: support reserving pods resources #2224

Conversation

saintube
Copy link
Member

Ⅰ. Describe what this PR does

Reservation supports reserving "pods" resources. It helps when we want to limit the allocatable "pods" of the reservation owners.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

Copy link

codecov bot commented Oct 14, 2024

Codecov Report

Attention: Patch coverage is 81.81818% with 4 lines in your changes missing coverage. Please review.

Project coverage is 67.33%. Comparing base (2fde51c) to head (34cde91).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pkg/scheduler/frameworkext/reservation_info.go 0.00% 2 Missing ⚠️
pkg/scheduler/plugins/reservation/transformer.go 33.33% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2224      +/-   ##
==========================================
+ Coverage   67.29%   67.33%   +0.03%     
==========================================
  Files         453      453              
  Lines       43687    43703      +16     
==========================================
+ Hits        29401    29427      +26     
+ Misses      11740    11731       -9     
+ Partials     2546     2545       -1     
Flag Coverage Δ
unittests 67.33% <81.81%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: saintube <saintube@foxmail.com>
@saintube saintube force-pushed the scheduler-reservation-support-pods branch from df47e05 to 34cde91 Compare October 15, 2024 11:46
@zwzhang0107
Copy link
Contributor

/lgtm
/approve

@koordinator-bot koordinator-bot bot merged commit 360c5d3 into koordinator-sh:main Oct 16, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants